feat(key-manager): implement JWE functionality directly in key-manager
#557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The KMS is only used to compute shared secret, it doesn't need to deal with JWE directly fixes #556
Codecov Report
@@ Coverage Diff @@
## next #557 +/- ##
==========================================
+ Coverage 67.58% 77.51% +9.93%
==========================================
Files 62 71 +9
Lines 1530 1890 +360
Branches 247 319 +72
==========================================
+ Hits 1034 1465 +431
- Misses 400 423 +23
+ Partials 96 2 -94 |
awoie
approved these changes
Jun 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KMS is only used to compute shared secret, it doesn't need to deal with JWE directly.
This PR moves the responsibility of createJWE and decryptJWE to the
key-managerlayer which eventually uses theshared secretfunctionality of the KMS to perform the same task.fixes #556