Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDR message handler assumes that message.data exists #560

Closed
rkreutzer opened this issue Jun 12, 2021 · 0 comments
Closed

SDR message handler assumes that message.data exists #560

rkreutzer opened this issue Jun 12, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@rkreutzer
Copy link
Contributor

Bug severity
3

Describe the bug
The message handler for selective disclosure requests expects that message.data exists when evaluating the first if statement in the program. Message.data will not exist in certain error conditions, like an expired JWT or an unsupported message type.

Optional chaining on those variables needs to be added to cause that if statement to return false, instead of failing.

Observed behaviour
The program fails due to messagedata.type and message.data.claims being undefined

Versions:

  • Veramo: 1.2.2
@rkreutzer rkreutzer added the bug Something isn't working label Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant