Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency ws to v8 #643

Merged
merged 1 commit into from
Jul 28, 2021
Merged

fix(deps): update dependency ws to v8 #643

merged 1 commit into from
Jul 28, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 28, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
ws ^7.4.1 -> ^8.0.0 age adoption passing confidence

Release Notes

websockets/ws

v8.0.0

Compare Source

Breaking changes

  • The WebSocket constructor now throws a SyntaxError if any of the
    subprotocol names are invalid or duplicated (0aecf0c).

  • The server now aborts the opening handshake if an invalid
    Sec-WebSocket-Protocol header field value is received (1877dde).

  • The protocols argument of handleProtocols hook is no longer an Array but
    a Set (1877dde).

  • The opening handshake is now aborted if the Sec-WebSocket-Extensions header
    field value begins or ends with a white space (e814110).

  • Dropped support for Node.js < 10.0.0 (552b506).

  • The WebSocket constructor now throws a SyntaxError if the connection URL
    contains a fragment identifier or if the URL's protocol is not one of 'ws:',
    'wss:', or 'ws+unix:' (ebea038).

  • Text messages and close reasons are no longer decoded to strings. They are
    passed as Buffers to the listeners of their respective events. Listeners of
    'message' event now take a boolean argument specifying whether or not the
    message is binary (e173423).

    Existing code can be migrated by decoding the buffer explicitly.

    websocket.on('message', function message(data, isBinary) {
      const message = isBinary ? data : data.toString();
      // Continue as before.
    });
    
    websocket.on('close', function close(code, data) {
      const reason = data.toString();
      // Continue as before.
    });
  • The package now uses an ES module wrapper (78adf5f).

  • WebSocketServer.prototype.close() no longer closes existing connections
    (df7de57).

    Existing code can be migrated by closing connections manually.

    websocketServer.close();
    for (const ws of websocketServer.clients) {
      ws.terminate();
    }
  • The callback of WebSocketServer.prototype.close() is now called with an
    error if the server is already closed (abde9cf).

  • Websocket.prototype.addEventListener() is now a noop if the type argument
    is not one of 'close', 'error', 'message', or 'open' (a421eb5).

  • Websocket.prototype.removeEventListener() now only removes listeners added
    with Websocket.prototype.removeEventListener() and only one at time
    (1bd93f0).

  • The value of the onclose, onerror, onmessage, and onopen properties is
    now null if the respective event handler is not set (45790db).

  • The OpenEvent class has been removed (c4394c3).

Bug fixes

  • The event listeners added via handler properties are now independent from the
    event listeners added with WebSocket.prototype.addEventListener()
    (0b21c03).

Configuration

πŸ“… Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the maintenance label Jul 28, 2021
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #643 (8389018) into next (88264db) will increase coverage by 10.20%.
The diff coverage is 71.12%.

❗ Current head 8389018 differs from pull request most recent head 9136048. Consider uploading reports for the commit 9136048 to get more accurate results

@@             Coverage Diff             @@
##             next     #643       +/-   ##
===========================================
+ Coverage   67.58%   77.78%   +10.20%     
===========================================
  Files          62       78       +16     
  Lines        1530     2345      +815     
  Branches      247      409      +162     
===========================================
+ Hits         1034     1824      +790     
- Misses        400      519      +119     
+ Partials       96        2       -94     

@mirceanis mirceanis merged commit 40fae61 into next Jul 28, 2021
@mirceanis mirceanis deleted the renovate/ws-8.x branch July 28, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants