Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dataStoreDeleteVerifiableCredential #652

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Conversation

simonas-notcat
Copy link
Contributor

Fixes: #649

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #652 (4d1cf26) into next (88264db) will increase coverage by 10.19%.
The diff coverage is 71.09%.

❗ Current head 4d1cf26 differs from pull request most recent head 1f45475. Consider uploading reports for the commit 1f45475 to get more accurate results

@@             Coverage Diff             @@
##             next     #652       +/-   ##
===========================================
+ Coverage   67.58%   77.77%   +10.19%     
===========================================
  Files          62       78       +16     
  Lines        1530     2344      +814     
  Branches      247      409      +162     
===========================================
+ Hits         1034     1823      +789     
- Misses        400      519      +119     
+ Partials       96        2       -94     

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mirceanis mirceanis merged commit 840d89b into next Aug 5, 2021
@mirceanis mirceanis deleted the fix/data-store-delete-vc branch August 5, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dataStoreDeleteVerifiableCredential will fail when the TypeORM is not using "default" name
2 participants