Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MessagingRouter save option #713

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Conversation

simonas-notcat
Copy link
Contributor

Fixes #712

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #713 (d60d285) into next (88264db) will increase coverage by 11.62%.
The diff coverage is 76.42%.

@@             Coverage Diff             @@
##             next     #713       +/-   ##
===========================================
+ Coverage   67.58%   79.20%   +11.62%     
===========================================
  Files          62       85       +23     
  Lines        1530     2592     +1062     
  Branches      247      463      +216     
===========================================
+ Hits         1034     2053     +1019     
- Misses        400      537      +137     
+ Partials       96        2       -94     

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
We should be removing the automatic saving from most places anyway :)

@mirceanis mirceanis merged commit 0ca9b44 into next Sep 30, 2021
@mirceanis mirceanis deleted the feat/messaging-router-save-option branch September 30, 2021 06:30
@mirceanis mirceanis mentioned this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] Add a flag to MessagingRouterOptions for automatically saving messages
2 participants