fix(data-store): add support for entityPrefix #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirceanis
changed the title
mirceanis
commented
Oct 21, 2021
| @@ -50,6 +50,7 @@ function createSchema(generator: TJS.SchemaGenerator, symbol: string) { | |||
| schemaStr = schemaStr.replace(/Where\<(.*)\>/gm, 'Where-$1') | |||
| schemaStr = schemaStr.replace(/Order\<(.*)\>/gm, 'Order-$1') | |||
| schemaStr = schemaStr.replace(/FindArgs\<(.*)\>/gm, 'FindArgs-$1') | |||
| schemaStr = schemaStr.replace(/https \:\/\//gm, 'https://') | |||
There was a problem hiding this comment.
Somewhere in the api-extractor toolchain there is a bug that introduces a space between https and ://.
This is a workaround.
Codecov Report
@@ Coverage Diff @@
## next #725 +/- ##
===========================================
+ Coverage 67.58% 79.03% +11.45%
===========================================
Files 62 85 +23
Lines 1530 2609 +1079
Branches 247 447 +200
===========================================
+ Hits 1034 2062 +1028
- Misses 400 545 +145
+ Partials 96 2 -94 |
rkreutzer
reviewed
Oct 21, 2021
great catch! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #724
I use the
Entitymetadata that TypeORM provides (which includes theentityPrefixconfigured on the connection) to decide on the database table names for migrations.I merged the pre-migration database fixtures into a single db and added another fixture to test migrations when
entityPrefixis used.This PR also contains some doc fixes for some core types and a workaround for a bug in the api-extractor toolchain that introduces some whitespace in
{@link URLs}.Also, the default
infuraProjectIdused in testing is updated.