Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import from external url #111

Closed
ericmillsio opened this issue Mar 20, 2014 · 5 comments
Closed

Import from external url #111

ericmillsio opened this issue Mar 20, 2014 · 5 comments

Comments

@ericmillsio
Copy link

Docker::Image.import should be able to import from an external url, not just from a local file. Would it work to use open-uri?
@nahiluhmot
Copy link
Contributor

Good point! I may not use open-uri (only because I don't want to add any more dependencies), but expect to see a pull regarding this soon.

@bfulton
Copy link
Contributor

bfulton commented Mar 21, 2014

Good idea. @nahiluhmot isn't open-uri part of Ruby?

@bfulton
Copy link
Contributor

bfulton commented Mar 21, 2014

@nahiluhmot also discussed adding an import_stream for anything that open-uri can't handle.

@nahiluhmot nahiluhmot mentioned this issue Mar 21, 2014
Merged
@nahiluhmot
Copy link
Contributor

This issue should be fixed in version 1.10.3. Feel free to re-open if your issue persists, @crearc

@ericmillsio
Copy link
Author

Wonderful! Thanks for being so quick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bfulton @ericmillsio @nahiluhmot