Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: URI.escape is obsolete (Ruby 2.7.0) #557

Closed
hezanathos opened this issue Jun 17, 2020 · 4 comments
Closed

Warning: URI.escape is obsolete (Ruby 2.7.0) #557

hezanathos opened this issue Jun 17, 2020 · 4 comments

Comments

@hezanathos
Copy link

URI.escape is obsolete in Ruby 2.7.0, so using the gem generates warnings.

/usr/local/bundle/gems/docker-api-1.34.2/lib/docker/image.rb:129: warning: URI.escape is obsolete

The problematic line is : https://github.com/swipely/docker-api/blob/master/lib/docker/image.rb#L129

@tas50
Copy link
Contributor

tas50 commented Jun 18, 2020

This fork has the fix for those warnings: https://github.com/chef/docker-api

@tlunter
Copy link
Contributor

tlunter commented Jun 18, 2020

There was a pull request opened here with regards to this issue here: #551 (comment) but notably swapping from URI.escape and URI.encode to CGI.escape doesn't seem to be a solution that works as a drop in (the tests for these cases fail).

@rmoriz
Copy link

rmoriz commented Jun 26, 2020

@tlunter As far as I can see the test pass and fail for older Rubies just because of a broken travis setup (bundler version)

@tlunter
Copy link
Contributor

tlunter commented Jul 21, 2020

Hey folks, can try now with v2.0.0.pre.1. There are some other changes in there that I think many folks would benefit from. Let me know if you see any issues.

@tlunter tlunter closed this as completed Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants