Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Implement generate to handle flag for writing to file #17

Closed
rytswd opened this issue Jul 16, 2021 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@rytswd
Copy link
Member

rytswd commented Jul 16, 2021

馃敭 Relevant Command

importer generate

馃梻 Language Type

All

馃攷 Request Details

Current importer generate implementation is not correct, as it simply updates the file in place.
Instead, importer generate should write to stdout by default, and when a flag is provided such as --out file.txt, it should be written to the provided file.

This would probably require a few flags in the end:

  • --out filename: write output to filename
  • --overwrite: when used with --out flag, ignore the existing file and overwrite
  • --remove-markers: remove Importer markers from the processed content
@rytswd rytswd added the enhancement New feature or request label Jul 16, 2021
@rytswd rytswd mentioned this issue Jul 19, 2021
@rytswd
Copy link
Member Author

rytswd commented Aug 10, 2021

importer generate now correctly generates the updated file data to stdout, or to a separate file.
There are a few options that are not yet supported, and thus those need to be tracked separately.
Ref: #35

@rytswd rytswd closed this as completed Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant