Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Handle same name importer marker #22

Closed
rytswd opened this issue Jul 21, 2021 · 1 comment
Closed

[Bug]: Handle same name importer marker #22

rytswd opened this issue Jul 21, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@rytswd
Copy link
Member

rytswd commented Jul 21, 2021

馃敄 Version

v0.0.1-rc4

馃搶 What happened?

When the same Improter marker name is used multiple times, Importer won't be able to process correctly.
This should be an error, but with the current version, this does not give you any error, and would try to process and end up with incorrect data.

Example:

# Test Markdown

<!-- == imptr: some_importer / begin from: ./some-data.md#1~2 == -->
<!-- == imptr: some_importer / end == -->

<!-- == imptr: some_importer / begin from: ./another-data.md#33~38 == -->
<!-- == imptr: some_importer / end == -->

馃 Relevant log output

No response

馃敆 Reference

No response

@rytswd rytswd added the bug Something isn't working label Jul 21, 2021
@rytswd
Copy link
Member Author

rytswd commented Aug 16, 2021

This is fixed with #39

@rytswd rytswd closed this as completed Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant