Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Project missing .jsonl file will not indicate it as a required file on Safari #600

Open
cfrenchi opened this issue Mar 7, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@cfrenchi
Copy link

cfrenchi commented Mar 7, 2024

Describe the bug
Followed the steps for the Dashboard outlined in Getting Started and successfully built the project and hosted it locally through docker. (Great work, the script went smooth!)

When creating a "New Project" in Safari I am only seeing errors for the text fields when left blank and not the "Choose File". If all fields are filled in except the .jsonl there is no warning and you are unable to proceed using "Next". If this is a required field, it should be marked in the UI when failing to provide it with correct file types.

To Reproduce
Steps to reproduce the behavior:

  1. Navigate in your browser (Safari) to your docker deployment localhost:port
  2. On the "Home" page, click "New Project"
  3. Enter in a value for the text fields
  4. Choose either "Evaluation" or "Prompt" (Both affected)
  5. Leave the "Choose File" blank
  6. Choose any Eval LLM
  7. Click "Next"
  8. There is no error, no warning.

Adding in a jsonl fixes this issue but without the visual indicator it doesn't seem like a required field and makes UX confusing.

Expected behavior
When creating a new project and the 'Choose File' field is missing a file, there should be a warning to attach a .jsonl that is a dataset. A description of what this file even is would be helpful as it is vague what this field is looking for other than the callout for .jsonl

Screenshots
image
Unable to click "Next" and there is no warning about the file being needed or what the file is

Additional context
It might be helpful to have an explanation of the fields or the importance of the .jsonl dataset during this process. How is this file being used? What is this file for?

System Environment
Sonoma 14.3.1
Safari 17.3.1
Docker 4.28.0

@cfrenchi cfrenchi added the bug Something isn't working label Mar 7, 2024
@Dominastorm
Copy link
Collaborator

Thanks for the suggestion, we will incorporate this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants