Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitizing SMILES removes chirality information #94

Closed
tianyu-lu opened this issue May 17, 2022 · 2 comments · Fixed by #97
Closed

Sanitizing SMILES removes chirality information #94

tianyu-lu opened this issue May 17, 2022 · 2 comments · Fixed by #97

Comments

@tianyu-lu
Copy link

On this line of sample_space(), chirality information of origin_smiles is removed. The output is then unsuitable as input to a chirality-aware ML model, e.g. to distinguish L vs. D amino acids which are important in models of binding affinity. Could the option to skip this sanitization step be provided to the user?

PS: Great code base and beautiful visualizations! We're finding it very useful in explaining our Gaussian Process models. The future of SAR ←→ ML looks exciting.

@whitead
Copy link
Contributor

whitead commented May 17, 2022

Hi @tianyu-lu. Yup good find. I think we need to split that function to be either canonicalize or sanitize. Will fix this shortly.

@whitead
Copy link
Contributor

whitead commented May 18, 2022

@tianyu-lu check-out the latest pre-release on pip, which should fix your problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants