Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignores SA:MP naming conventions #1

Closed
Y-Less opened this issue Dec 16, 2017 · 0 comments
Closed

Ignores SA:MP naming conventions #1

Y-Less opened this issue Dec 16, 2017 · 0 comments

Comments

@Y-Less
Copy link
Contributor

Y-Less commented Dec 16, 2017

Most of SA:MP (core, libraries, and plugins) are written as:

Library_FunctionName, but this for some reason ignores that and uses library_function_name. Can this be corrected to better match all other code?
Y-Less added a commit to Y-Less/Pawn.Regex that referenced this issue Dec 16, 2017
@Y-Less
SA:MP naming conventions, and strong tags.
2837f94 
The code previously went against SA:MP naming conventions (see katursis#1).  This adds in the correct naming scheme while keeping (but deprecating) the old one without modifying the DLL.  Also changes `regex:` to `Regex:` and `match_results:` to the less generic `RegexMatch:` (still don't like the `MATCH_DEFAULT` and similar symbols - nothing about that name indicates that it is part of the Regex system, increasing the likelihood of a naming collision).  Those name changes however are mostly motivated by making the tags strong - case matters semantically in tags.
@katursis katursis mentioned this issue Dec 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Y-Less @katursis