Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't display category for public users if it's empty #26

Closed
elioqoshi opened this issue Nov 14, 2017 · 15 comments
Closed

don't display category for public users if it's empty #26

elioqoshi opened this issue Nov 14, 2017 · 15 comments
Labels
2. enhancement This issue proposes an enhancement of an existing feature 3. good first issue Easily fixable
Milestone

Comments

@elioqoshi
Copy link
Contributor

elioqoshi commented Nov 14, 2017

Currently, if a Category has no assets, it's still displayed, even publicly:
image
(project in the example: https://demo.identihub.co/project/mozilla-reps/ )
The screenshot is from a public instance. It even suggests to write a title or add a new image (which is supposed to be for admins)

Categories which don't have any assets added to them should not be displayed for public users.
Example (project with no Images category):

image

Same should go with other Categories. e.g if no font is added, the Fonts section should not appear for public users.

@elioqoshi elioqoshi added 2. enhancement This issue proposes an enhancement of an existing feature 3. good first issue Easily fixable labels Nov 14, 2017
@elioqoshi elioqoshi added this to the v0.2 milestone Nov 14, 2017
@brantje
Copy link
Contributor

brantje commented Nov 14, 2017

In this function there needs to be a check if the project is not empty.

@tstreamDOTh
Copy link

@elioqoshi I would like to work on this

@elioqoshi
Copy link
Contributor Author

@tstreamDOTh Of course! Every contribution is appreciated! Sent us a PR and we will review it and let me know if you need anything :)

@tstreamDOTh
Copy link

@elioqoshi I am getting an error which says "Whoops, looks like something went wrong.". Do we need to setup environment variables or something? Could you add a little help in the documentation.

@elioqoshi
Copy link
Contributor Author

@tstreamDOTh I think that's a generic Laravel error. Have you checked the authentication key? We are working on some documentation to have it ready on Monday.

@ilirhushi our dev might be able to assist maybe?

@elioqoshi
Copy link
Contributor Author

I suppose you used Homestead as written in the readme?

@ilirhushi
Copy link
Contributor

@tstreamDOTh could you provide more details of you scenario?

@ilirhushi
Copy link
Contributor

@elioqoshi I fixed this, I will update the server soon.

@elioqoshi
Copy link
Contributor Author

@ilirhushi thanks. Let me know if it works so we can close this

ilirhushi added a commit that referenced this issue Nov 19, 2017
@ilirhushi
Copy link
Contributor

@elioqoshi check now, because I updated the demo server

@elioqoshi
Copy link
Contributor Author

The Images category still appears here although it's empty:
https://demo.identihub.co/project/mozillareps

@elioqoshi elioqoshi assigned chrispecoraro and budaaaa and unassigned ilirhushi Jan 10, 2018
@elioqoshi
Copy link
Contributor Author

@chrispecoraro @budaaaa assigning these to you

@rskikuli
Copy link
Contributor

@budaaaa ping about this.

@budaaaa
Copy link
Contributor

budaaaa commented Mar 19, 2018

@rskikuli This one is completed since Jan. Waiting for team to confirm so the issue can be closed

@elioqoshi
Copy link
Contributor Author

This is implemented and works great, closing. Thanks!

This was referenced Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. enhancement This issue proposes an enhancement of an existing feature 3. good first issue Easily fixable
Projects
None yet
Development

No branches or pull requests

7 participants