New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't display category for public users if it's empty #26
Comments
In this function there needs to be a check if the project is not empty. |
@elioqoshi I would like to work on this |
@tstreamDOTh Of course! Every contribution is appreciated! Sent us a PR and we will review it and let me know if you need anything :) |
@elioqoshi I am getting an error which says "Whoops, looks like something went wrong.". Do we need to setup environment variables or something? Could you add a little help in the documentation. |
@tstreamDOTh I think that's a generic Laravel error. Have you checked the authentication key? We are working on some documentation to have it ready on Monday. @ilirhushi our dev might be able to assist maybe? |
I suppose you used Homestead as written in the readme? |
@tstreamDOTh could you provide more details of you scenario? |
@elioqoshi I fixed this, I will update the server soon. |
@ilirhushi thanks. Let me know if it works so we can close this |
@elioqoshi check now, because I updated the demo server |
The Images category still appears here although it's empty: |
@chrispecoraro @budaaaa assigning these to you |
@budaaaa ping about this. |
@rskikuli This one is completed since Jan. Waiting for team to confirm so the issue can be closed |
This is implemented and works great, closing. Thanks! |
Currently, if a Category has no assets, it's still displayed, even publicly:
(project in the example: https://demo.identihub.co/project/mozilla-reps/ )
The screenshot is from a public instance. It even suggests to write a title or add a new image (which is supposed to be for admins)
Categories which don't have any assets added to them should not be displayed for public users.
Example (project with no Images category):
Same should go with other Categories. e.g if no font is added, the Fonts section should not appear for public users.
The text was updated successfully, but these errors were encountered: