Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream.Read return value is ignored #1

Closed
tshcherban opened this issue Aug 27, 2018 · 2 comments
Closed

stream.Read return value is ignored #1

tshcherban opened this issue Aug 27, 2018 · 2 comments

Comments

@tshcherban
Copy link

xxHash/src/Standart.Hash.xxHash/xxHash64.Stream.cs

Line 59 in f5d67a1

stream.Read(buffer, 0, bufferSize);

There might be an issue if stream.read returned less than bufferSize (e.g. NetworkStream), invalid hash is calculated.
@uranium62
Copy link
Owner

Hi @tshcherban
Thank you very much for this issue.
I am going to rewrite the stream implementation using pipes and fix the bug.
Your raised very serious problem about it I have never thought before

@uranium62
Copy link
Owner

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uranium62 @tshcherban