-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Carthage option #9
Comments
We will look into this in the next release. I think we just need to modify some search paths to make it work with both cocoapods and carthage. |
@rlepinski Ryan, sounds good, thanks. Basically it's about adding proper headers and references inside search paths inside Xcode settings. I did relevant changes, but it's not PR ready yet – eugenehp@a272da4 another thing I wanted to ask, is an ability to execute configuration of the module inside JS, this way we can reuse environment settings inside JS VM. Thanks. |
@eugenehp You mean being able to configure UAirship from JS? The main issue with that is UAirship needs to be ready before application:didFinishLaunching: on iOS and in the Application (background start) on Android. What we have done in other plugins is allow the initial config to be done at a later time and automatically use those settings on subsequent launches. If that method gets called again with different values UAirship will continue to use the old values until the next launch. Totally possible but its not the most ideal setup. |
@rlepinski thanks for the feedback, looks like I'll need to think more on this. |
@eugenehp Added Carthage support. We have a ticket in our backlog to enable takeoff from JS, will be released in a future version. Closing this for now since it was initially for carthage support. |
Cocoapod is good, but would be great to have Carthage option in here:
https://github.com/urbanairship/ios-library#carthage
The text was updated successfully, but these errors were encountered: