Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Carthage option #9

Closed
eugenehp opened this issue May 22, 2017 · 5 comments
Closed

Add Carthage option #9

eugenehp opened this issue May 22, 2017 · 5 comments

Comments

@eugenehp
Copy link

Cocoapod is good, but would be great to have Carthage option in here:
https://github.com/urbanairship/ios-library#carthage

@rlepinski
Copy link
Collaborator

We will look into this in the next release. I think we just need to modify some search paths to make it work with both cocoapods and carthage.

@eugenehp
Copy link
Author

@rlepinski Ryan, sounds good, thanks. Basically it's about adding proper headers and references inside search paths inside Xcode settings. I did relevant changes, but it's not PR ready yet – eugenehp@a272da4

another thing I wanted to ask, is an ability to execute configuration of the module inside JS, this way we can reuse environment settings inside JS VM.
Let me know your thoughts on this.

Thanks.

@rlepinski
Copy link
Collaborator

@eugenehp You mean being able to configure UAirship from JS? The main issue with that is UAirship needs to be ready before application:didFinishLaunching: on iOS and in the Application (background start) on Android.

What we have done in other plugins is allow the initial config to be done at a later time and automatically use those settings on subsequent launches. If that method gets called again with different values UAirship will continue to use the old values until the next launch.

Totally possible but its not the most ideal setup.

@eugenehp
Copy link
Author

@rlepinski thanks for the feedback, looks like I'll need to think more on this.

@rlepinski
Copy link
Collaborator

@eugenehp Added Carthage support. We have a ticket in our backlog to enable takeoff from JS, will be released in a future version. Closing this for now since it was initially for carthage support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants