Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove_terminal_sn not working for all GTFS feeds #37

Closed
AlexandraKapp opened this issue Aug 6, 2020 · 1 comment
Closed

remove_terminal_sn not working for all GTFS feeds #37

AlexandraKapp opened this issue Aug 6, 2020 · 1 comment
Projects
v0.1-0.1.1

Comments

@AlexandraKapp
Copy link
Contributor

https://github.com/ATFutures/gtfs-router/blob/44f8e43df3dd85c7488e66e33e789967e021dcf6/R/extract-gtfs.R#L77

e.g. VRR Feed has endings with "S" that are valid and need to be kept.
@mpadge mpadge closed this as completed in f386c97 Aug 13, 2020
@mpadge
Copy link
Member

mpadge commented Aug 13, 2020

That commit implements a new parameter: extract_gtfs (..., stn_suffixes = NULL). Any non-NULL values will be removed from the end of station ID entries, including potential multi-character strings. Thanks for noting that!

@mpadge mpadge added this to CRAN v0.0.3 in v0.1-0.1.1 Aug 13, 2020
@mpadge mpadge moved this from CRAN v0.0.3 to CRAN v0.0.2 in v0.1-0.1.1 Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
v0.1-0.1.1
CRAN v0.0.5
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpadge @AlexandraKapp