Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Android part of repo fork friendly #11

Closed
aaronjwood opened this issue Oct 7, 2018 · 3 comments
Closed

Make Android part of repo fork friendly #11

aaronjwood opened this issue Oct 7, 2018 · 3 comments

Comments

@aaronjwood
Copy link

After forking and opening the Android code base in Android Studio there are some errors that devs will hit:

  1. Key doesn't exist (can be sidestepped by commenting out the signingConfigs section along with this)
  2. Library doesn't exist (this is where I'm currently at, where can I get this?)
@Artaud
Copy link
Collaborator

Artaud commented Oct 8, 2018

Mkay this is stupid from me, sorry!

  1. Yes, please do as you say.

  2. This is our internal common library, there is actually just one usage of it which you could comment out (this line)
    but then your fork wouldn't be able to assemble debug reports in the same way as the original.
    So the library is here:
    urbandroidcommon1.5.zip
    Unpack it into your local maven repository, so the final path would be ~/.m2/repository/com/urbandroid/common/1.5

@aaronjwood
Copy link
Author

Awesome, thanks! Can the common lib be open sourced so that people don't need to manually come here and download a zip file?

@Artaud
Copy link
Collaborator

Artaud commented Oct 16, 2018

Added in 0d0d2df
It's not open sourced really but I included the aar in the project and linked to it in the gradle file, so it's hassle-free now.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants