Bug? Dynamic sources and layers

[lapidus]

I am rendering a dynamic list of Sources and Layers:

// inside react render ... 

{ sources.map(s => (
    <Source [some props] />
))}
{sources.map(s => (
     <Layer [some props] />
))}

This works well on load but when I subsequently filter sources, I get this type of error:

Source "primary" cannot be removed while layer "primary" is using it

It seems the mapbox operation under the hood is asynchronous so that I cannot delete a source in the same render as I delete a layer. How can I work around this? Or could you possibly build in some safeguards against this behaviour?

Thanks!

[stepankuzmin]

Hi @lapidus! Thanks for the issue!

What version do you use? Could you please provide a reproducible example?

[lapidus]

Hi!

It seems they had the same issue here:
alex3165/react-mapbox-gl#493

And resolved by removing layers before sources:
alex3165/react-mapbox-gl@986b555

[lapidus]

I could try to do a PR later, any hints appreciated :)

[lapidus]

Gah, gosh! I just realized you fixed this 6 days ago:
3f228af#diff-c4273adc64deb9bc0ebb2446633a17cd

I was still on version 1.3. Sorry about that and thank you for a great lib!

[stepankuzmin]

No problem, glad to hear that this worked for you :)