Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testify, and update tests to use it rather than expect #1695

Closed
3 tasks done
Tracked by #833
skelouse opened this issue Mar 6, 2023 · 2 comments · Fixed by #1853
Closed
3 tasks done
Tracked by #833

Add testify, and update tests to use it rather than expect #1695

skelouse opened this issue Mar 6, 2023 · 2 comments · Fixed by #1853
Assignees
Labels
area/v3 relates to / is being considered for v3 status/triage maintainers still need to look into this
Milestone

Comments

@skelouse
Copy link
Contributor

skelouse commented Mar 6, 2023

Checklist

  • Are you running the latest v3 release? The list of releases is here.
  • Did you check the manual for your release? The v3 manual is here.
  • Did you perform a search about this feature? Here's the GitHub guide about searching.

What problem does this solve?

Simplifies tests, i.e

if err != nil {
	t.Error(err)
	return
}

Becomes

assert.NilError(t, err)

Solution description

import stretchr/testify in tests and replace value checking in tests with testify

@skelouse skelouse added status/triage maintainers still need to look into this area/v3 relates to / is being considered for v3 labels Mar 6, 2023
@skelouse skelouse reopened this Mar 18, 2023
@skelouse
Copy link
Contributor Author

@dearchap was there a reason for the close? I opened this based on a comment on the mentioned PR.

@dearchap
Copy link
Contributor

Ah ok. Sorry I thought that PR was the fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v3 relates to / is being considered for v3 status/triage maintainers still need to look into this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants