Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor usage of github.com/xrash/smetrics for suggestions #1892

Closed
Tracked by #1890
meatballhat opened this issue Apr 28, 2024 · 2 comments · Fixed by #1893
Closed
Tracked by #1890

Vendor usage of github.com/xrash/smetrics for suggestions #1892

meatballhat opened this issue Apr 28, 2024 · 2 comments · Fixed by #1893
Assignees
@yigithankarabulut
Labels
area/v3 relates to / is being considered for v3 good first issue Easy fix for newcomers help wanted please help if you can!
Milestone
Release 3.x

Comments

@meatballhat
Copy link
Member

meatballhat commented Apr 28, 2024 •
edited

The usage of smetrics.JaroWinkler should be vendored into this source tree or replaced with an implementation that is within this source tree to support the goal of only requiring the Go standard library.
@meatballhat meatballhat mentioned this issue Apr 28, 2024
Open
1 task
@meatballhat meatballhat added this to the Release 3.x milestone Apr 28, 2024
@meatballhat meatballhat added help wanted please help if you can! area/v3 relates to / is being considered for v3 good first issue Easy fix for newcomers labels Apr 28, 2024
@yigithankarabulut
Copy link
Contributor

smetrics.JaroWinkler on line 25 in suggestions.go file, do we need to write this function instead of using it? If so, could you assign to me?

@meatballhat
Copy link
Member Author

@yigithankarabulut Thank you! Replacing the function usage with an internal function SGTM. Vendoring the library implementation with attribution is also acceptable. Your call!

@yigithankarabulut yigithankarabulut mentioned this issue Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yigithankarabulut yigithankarabulut

Labels
area/v3 relates to / is being considered for v3 good first issue Easy fix for newcomers help wanted please help if you can!
Projects
None yet
Milestone
Release 3.x
Development

Successfully merging a pull request may close this issue.

Replace Jaro-Winkler algorithm usage with an internal function yigithankarabulut/cli
2 participants
@meatballhat @yigithankarabulut