Different Args in "Action" and "Before" functions

[igm]

I recently came across a problem when accessing Args from Context. I expected to get the same args in "Action" and "Before" functions, but "Action" has it's name at index 0 and arguments start from index 1, in "Before" arguments start from index 0.

An example to demonstrate: http://play.golang.org/p/CIrOdw3noq

Also looking at the examples https://github.com/codegangsta/cli#subcommands
I'd expect c.Args().First() to contain the first argument, not the command name itself. Is this desired behaviour, please?

[igm]

It seems it is more inconsistent than that. If "Before" is nil, "Action" does not have its name at index 0.
example main.go: http://play.golang.org/p/dKDdOWqL8S

$ go run main.go foo 1 2 3 4
Args in Before: [1 2 3 4]
Args in Action: [foo 1 2 3 4]

$ go run main.go bar 1 2 3 4
Args in Action: [1 2 3 4]

[fatih]

Confirmed, setting the "Before" function disables argument parsing of my defined flags. I removed Before functions completely.

[codegangsta]

This is definitely a bug. Thanks for the report

[ghigt]

This bug is due to these lines (#L211):

// Run default Action
if len(a.Commands) > 0 {
    a.Action(context)
} else {
    a.Action(ctx)
}

@codegangsta, I think we should remove this if statement. It is apparently not necessary.

EDIT: There is already a discussion about this issue in the responsible commit.

[jszwedko]

Addressed by #170

[cvik]

Great, just found this bug as well and can confirm it. My research also found the lines above by ghigt.

The Ctx context haven't yet parsed the flags for the subcommand, but context context has and that one is used by the Before action, which makes it look like it works for Before, but not Action of the subcommand.

Any ETA when a fix can be merged to master?

[jszwedko]

@rawn merged in today, let me know if your issue persists.

[cvik]

@jszwedko Works beautifully!