Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete on ITrackableRepository #18

Closed
ferryferry opened this issue Mar 1, 2018 · 6 comments
Closed

Delete on ITrackableRepository #18

ferryferry opened this issue Mar 1, 2018 · 6 comments
Assignees
Labels
invalid This doesn't seem right

Comments

@ferryferry
Copy link

Hi,

Today I was testing with URF.Core..

I created a delete API function to delete a tweet from the database
image

After the function has ran, it gives me an "200" Ok response, but when I check the database, the tweet with id 1 is still there.

Am I doing something wrong?

@lelong37
Copy link
Member

lelong37 commented Mar 7, 2018

@ferryferry we've ran integration tests on our side, and it is successful w/ our tests.

  • Could you check to make sure you're running latest URF.Core packages?
  • If this isn't resolved after updating to URF.Core latest NuGet packages, could you be so kind to submit a PR with it failing so we can reproduce what your experiencing on your side?

http://localhost:2790/odata/Products(79)

image

Before:
image

Debugging:

2018-03-07_6-16-11

After:
image

@lelong37 lelong37 added the invalid This doesn't seem right label Mar 7, 2018
@lelong37 lelong37 self-assigned this Mar 7, 2018
@tonysneed
Copy link
Contributor

@lelong37 Do we call apply changes in the delete method?

@tonysneed
Copy link
Contributor

Now that I think about it, maybe it’s better if we just updated the individual entity stayed here?

@lelong37
Copy link
Member

lelong37 commented Mar 7, 2018

Absolutely positively, however this was added in the latest release betav2 #16, hence the request for @ferryferry to double check he's on the latest bits.

@lelong37
Copy link
Member

lelong37 commented Mar 7, 2018

@ferryferry we've also just updated URF.Sample which has Delete Action https://github.com/urfnet/URF.Core.Sample.

@tonysneed
Copy link
Contributor

Related: #19. Does not address this issue per se, but makes the behavior more consistent.

@lelong37 lelong37 closed this as completed Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants