Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Minor documentation expansion on use of std::bind() for events. #1760

Closed
wants to merge 25 commits into from
Closed

Minor documentation expansion on use of std::bind() for events. #1760

wants to merge 25 commits into from

Conversation

100espressos
Copy link
Contributor

No description provided.

@cadaver
Copy link
Contributor

cadaver commented Jan 16, 2017

Can someone who has used std::bind for events comment? (or merge directly, if good)

@100espressos
Copy link
Contributor Author

I changed my events to this syntax and it seems to work (I'm using GCC 6.3.1) .. I made the PR because the former syntax (without placeholders) errored with incorrect number of arguments also on MinGW/GCC 6, but I am curious what others experience.

@weitjong weitjong force-pushed the master branch 2 times, most recently from c2a1100 to c629ed1 Compare February 19, 2017 12:28
cadaver and others added 13 commits February 20, 2017 21:14
@cadaver
Remove semicolon from shader transform (iModelMatrix) macros, as it s…
7d06916 
…hould instead be part of the statement where the macro is being used. Closes #1829.
@cadaver
Add EndAllViewsRender event, emitted when Renderer::Render() is finis…
7451d6f 
…hed. Closes #1830.
@urho3d-travis-ci
Travis CI: API documentation update at 2017-02-20 19:27:37 UTC.
af1aba2 
[ci package]

Commit: 7451d6f

Message: Add EndAllViewsRender event, emitted when Renderer::Render() is finished. Closes #1830.
@weitjong
Add new option to control how to share resources on web platform.
f38487f 
Related to #1762.
Bugfix for vegetation shader and instancing.
25612d6
@weitjong
For CI - use the new build option to reduce number of changed objects.
5ffb40b 
Close #1762.
@cadaver
Add other body nodeID attribute to Constraint2D for proper body conne…
e1202b7 
…ction serialization. Closes #1825.
@urho3d-travis-ci
Travis CI: API documentation update at 2017-02-25 12:46:18 UTC.
1760b0f 
[ci package]

Commit: e1202b7

Message: Add other body nodeID attribute to Constraint2D for proper body connection serialization. Closes #1825.
@1vanK
Rename CheckDrawableVisibility() to CheckDrawableVisibilityWork() to …
779d283 
…match common style
@weitjong
For CI - only upload web samples when it is a master CI build.
5fe936e 
[ci skip]
@cadaver
Merge pull request #1834 from 1vanK/master
d710b29 
Rename CheckDrawableVisibility() to CheckDrawableVisibilityWork() to …
@weitjong
For CI - correct the "master" branch name for Web-CI build.
69b7a9d 
[ci only: Web] [skip appveyor]
Minor documentation expansion on use of std::bind() for events.
84a1f82
@rokups
Copy link
Contributor

rokups commented Feb 28, 2017

Yes this is correct.

@cadaver
Copy link
Contributor

cadaver commented Mar 2, 2017

Can you rebase or preferably use a feature branch? As of now this PR looks scary.

@100espressos
Copy link
Contributor Author

I think now it should look a bit less scary.

@cadaver
Copy link
Contributor

cadaver commented Mar 2, 2017

Thanks, merging would still add several merge commits to the history, but can do a squash merge.

@cadaver
Copy link
Contributor

cadaver commented Mar 2, 2017

Merged.

@cadaver cadaver closed this Mar 2, 2017
@100espressos
Copy link
Contributor Author

I see what happened, will avoid that in the future.

@weitjong weitjong added this to the 1.7 milestone Oct 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
документация
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@100espressos @cadaver @rokups @weitjong @urho3d-travis-ci @1vanK