This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
AngelScript auto subscribe to events. #2529
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to events based on their name.
…ated from script's Node.CreateScriptObject.
ArnisLielturks
suggested changes
Feb 3, 2020
| globalVars["GlobalName"] must be object handle to Object-derived class | ||
| and GlobalName may not contain '_'. | ||
|
|
||
| When script object created by deserialization of scene, subscription occurs at the moment after setting the attributes, |
There was a problem hiding this comment.
When script object is created by deserialization of a scene
| object is created and its Start method is called. If child nodes not exists, or script object attributes are not set, | ||
| then their events are not subscribed. | ||
|
|
||
| If script object created from C++ code by ScriptInstance::CreateObject, subscription not maked, and you must |
There was a problem hiding this comment.
subscription not maked, and you must call ScriptInstance::SubscribeToAutoEvents.
change to something like
automatic subscription will not be made, so you must call ScriptInstance::SubscribeToAutoEvents.
Comment on lines
+70
to
+80
| enum SubscribeType { | ||
| sCommon, // to all sources with this event, 'on_EventName' | ||
| sNode, // to events from that node, 'onNode_EventName' | ||
| sScene, // to events from scene, 'onScene_EventName' | ||
| sParent, // to events from parent node, 'onParent_EventName' | ||
| sModule, // to events from script file 'onModule_EventName' | ||
| sChild, // to events from child node, 'onChild_ChildName_EventName' | ||
| sAttr, // to events from attribute, 'onAttr_AttributeName_EventName' | ||
| sVar, // to events from script global var 'onVar_VariableName_EventName' | ||
| sGlobal, // to events from context global var'onGlobal_KeyName_EventName' | ||
| }; |
There was a problem hiding this comment.
padding should be fixed
| @@ -961,6 +995,195 @@ void ScriptInstance::HandleScriptFileReloadFinished(StringHash eventType, Varian | |||
| } | |||
| } | |||
|
|
|||
| static bool isMethodCanBeEventHandler(asIScriptFunction* pFunc) | |||
There was a problem hiding this comment.
isMethodCanBeEventHandler sounds wrong. Can we rename it to something like canMethodBeEventHandler?
|
Marking this stale since there has been no activity for 30 days. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow autosubscribe to events methods in instances of ScriptObject-derived classes, based on their names.