This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
TmxFile2D: Fix determination of object type #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TmxObjectGroup2D::Load was using the presence of the "width" and "height" attributes for deciding whether an object was a rectangle, ellipse or something else. This is wrong, and the approach breaks for maps saved in more recent versions of Tiled. This is because the width and height are only saved when they differ from the default (0), and because the width and height are now also used to store the size of tile objects. So for maps saved with Tiled >= 0.12, this change: * Fixes identification of rectangle and ellipse objects with 0 width and height (which was leading to the entire map failing to load). * Fixes identification of tile objects.
|
Thanks, nice to get a fix from the author himself! |
|
We needed this fix for LucKeyProductions/KO, a game my brother is working on and I was helping him integrate Tiled for level editing. :-) I consider the issue here somewhat my fault, for making the TMX format a little confusing. It happened due to the continuous adding of unanticipated features. It's hard to describe all these details and unfortunately the sheer amount of TMX support libraries out there are almost consistently out of date. Maybe I'll have more changes later. :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TmxObjectGroup2D::Load was using the presence of the "width" and "height" attributes for deciding whether an object was a rectangle, ellipse or something else. This approach breaks for maps saved in more recent versions of Tiled. This is because the width and height are only saved when they differ from the default (0), and because the width and height are now also used to store the size of tile objects.
So for maps saved with Tiled >= 0.12, this change: