Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch API to Mint #3

Closed
sanbox-irl opened this issue Nov 1, 2021 · 2 comments
Closed

Switch API to Mint #3

sanbox-irl opened this issue Nov 1, 2021 · 2 comments

Comments

@sanbox-irl
Copy link

Instead of using Into f32 arrays, using Mint can be much more convenient for both this library, and for users
@urholaukkarinen
Copy link
Owner

At first I went with Into<[[f32; 4]; 4]>, because the public api currently only takes 4x4 matrices and all of the most common math crates seem to support such conversion. Using Mint types might make it a bit more flexible, though.
I suppose with Mint it would be Into<ColumnMatrix4> instead of Into<[[f32; 4]; 4]>?

@urholaukkarinen
Copy link
Owner

If this is something you would really like to have, feel free to create a new issue and I'll look into it again. I'm closing this one as stale.

@urholaukkarinen urholaukkarinen closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2022
@kvark kvark mentioned this issue Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@urholaukkarinen @sanbox-irl