Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap section needs some clarification #38

Closed
robertlight opened this issue Apr 10, 2016 · 2 comments
Closed

bootstrap section needs some clarification #38

robertlight opened this issue Apr 10, 2016 · 2 comments

Comments

@robertlight
Copy link
Contributor

PROBLEM 1: In the bootstrap section it should warn you about the fact that lots of warning messages will ensue out of meteor/npm as a result of:

$ meteor npm install --save angular2-meteor
npm WARN peerDependencies The peer dependency angular2@2.0.0-beta.12 included from angular2-meteor will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency 
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency es6-shim@^0.35.0 included from angular2 will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency 
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency reflect-metadata@0.1.2 included from angular2 will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency 
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency rxjs@5.0.0-beta.2 included from angular2 will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency 
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency zone.js@^0.6.6 included from angular2 will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency 
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
zone.js@0.6.10 node_modules/zone.js

reflect-metadata@0.1.2 node_modules/reflect-metadata

es6-shim@0.35.0 node_modules/es6-shim

rxjs@5.0.0-beta.2 node_modules/rxjs

angular2@2.0.0-beta.12 node_modules/angular2

angular2-meteor@0.5.2 node_modules/angular2-meteor
├── fs.extra@1.3.2 (mkdirp@0.3.5, walk@2.3.9, fs-extra@0.6.4)
├── ejson@2.1.2 (underscore@1.8.3)
└── gulp-git@1.7.1 (any-shell-escape@0.1.1, require-dir@0.1.0, through2@0.6.5, gulp-util@3.0.7)

If this isn't what is supposed to happen - am I going off the beaten path? I have started from a blank directory until this point.

PROBLEM 2: A bit further down in section 0.9 the text needs to be fixed as the import is no longer from 'angular2/platform/browser'

First we're importing the dependencies we needed from angular2/core and angular2/platform/browser.
This is not a folder and files in your directory, but a reference to System.js modules aliased as
angular2/core and angular2/platform/browser. They are some of the Angular 2 main modules that are
available as part of the urigo:angular2-meteor package.

PROBLEM 3: In the section 'Typescript Typings"

This section seems to be out of date - in section 0.4 we created 'tsconfig.json' but didn't add a files section. Also we don't get the console messages described in this section any more.

It also says that "on first run, it creates a 'typings' folder - which it doesn't.

Moreover, the line "import {bootstrap} from 'angular2/platform/browser';" is just plain wrong.

@dotansimha
Copy link
Collaborator

Fixed in #45.
Waiting for @Urigo to approve.

@Urigo
Copy link
Owner

Urigo commented Apr 11, 2016

deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants