Can timezone be non-constant?

[hoopes]

I'd really like the option of being able to switch timezone dynamically. Is that an option? Any guidance for your preferred implementation of that (if I were to find some time to do it)?

[akarl]

Came here for this.

How about the possibility to set the timezone as a function?

this.applyTimezone = function (aMoment) {
    var timezone = angularMomentConfig.timezone;

    // Adding this check to be able to set the timezone from a function
    if (typeof timezone === 'function') {
        timezone = timezone();
    }

    if (aMoment && timezone) {
        if (aMoment.tz) {
            aMoment = aMoment.tz(timezone);
        } else {
            $log.warn('angular-moment: timezone specified but moment.tz() is undefined. Did you forget to include moment-timezone.js?');
        }
    }
    return aMoment;
};

I would have time to do a PR if the solution is ok.

[Mathbl]

+1

[demisx]

+1

[franleplant]

+1!

[franleplant]

When would this be merged?

[urish]

I believe it would make more sense to expose an API for changing the timezone rather than passing a function here. Something like: amMoment.changeTimezone('UTC');. This alternative seems to be more consistent with the amMoment.changeLocale() API we already have.

Thoughts?

[franleplant]

@urish your proposal seams cleaner 👍

[akarl]

@urish I agree, that's a better fix than mine

[vdsabev]

+1, we will be using this

[jirihelmich]

What about adding an additional param to the format filter? In my app, the timezone is different quite often and there is nothing like default display timezone. I wouldn't configure any and use just those.

For others, the default could stay and this one would override it locally.

[urish]

Anybody up to creating a PR for the amMoment.changeTimezone() proposal?

Thanks!

[bierdok]

+1 for amMoment.changeTimezone([string]) !

[bierdok]

it can be useful with this https://github.com/cmmartin/ngTimezone

[bierdok]

you can do that

angular
    .module('helloworld.moment', [
        'angularMoment',
        'ngTimezone'
    ]).run(function($timezone, angularMomentConfig) {
        angularMomentConfig.preprocess = 'utc';
        angularMomentConfig.timezone = $timezone.getName();
    });

[ansonphong]

I second @jirihelmich - there is no constant time zones in the app I'm building. I need the option to switch the timezone dynamically using a filter.