Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amLang pipe implemented #155

Merged
merged 2 commits into from Jul 14, 2017
Merged

amLang pipe implemented #155

merged 2 commits into from Jul 14, 2017

Conversation

FallenRiteMonk
Copy link
Contributor

As wanted in #154

@urish
Copy link
Owner

urish commented Jul 14, 2017

Thank you very much!

Actually, it would make more sense to align with moment.js naming convention, and call it amLocale. Do you also think so?

@FallenRiteMonk
Copy link
Contributor Author

Yes! I just didn't do it because of the naming in PR #153!

It's your decision, if you want I can change it!

@urish
Copy link
Owner

urish commented Jul 14, 2017

Let's do it then :)

@FallenRiteMonk
Copy link
Contributor Author

Ok give me a minute!

@urish urish merged commit 2d33056 into urish:master Jul 14, 2017
@urish
Copy link
Owner

urish commented Jul 14, 2017

Lovely, thanks!

@urish
Copy link
Owner

urish commented Jul 14, 2017

Released as 1.5.0

@quedicesebas
Copy link

And what about a global config?

@quedicesebas
Copy link

moment.locale('es') works for change locale globally but if pipes use import * as moment from 'moment/min/moment-with-locales'; instead of import * as moment from 'moment';. I tried to change tha in this library bu I always get an error (Could not find a declaration file for module 'moment/min/moment-with-locales'. 'c:/Users/Sebastián/Documents/GitHub/angular2-moment/node_modules/moment/min/moment-with-locales.js' implicitly has an 'any' type. Try npm install @types/moment/min/moment-with-locales if it exists or add a new declaration (.d.ts) file containing declare module 'moment/min/moment-with-locales';) so I ended up making the pipe in my project (where I can import moment with locales)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants