TimeAgoPipe doesn't support string dates when fullTemplateTypeCheck is enabled

[theodorejb]

There are a bunch of places in my HTML templates that use the amTimeAgo pipe like this:

{{myObj.someDateProp | amTimeAgo}}

Where someDateProp is an ISO8601 date string. This has been working without any issues so far.

However, when I try to enable the fullTemplateTypeCheck Angular compiler option, I get an error saying "Argument of type 'string' is not assignable to parameter of type 'Date | Moment'."

It looks like this is because the transform method of TimeAgoPipe specifies a type of Date or Moment, even though the underlying code supports strings and numbers too.

ngx-moment/src/time-ago.pipe.ts

Line 21 in 834d75f

transform(value: Date | moment.Moment, omitSuffix?: boolean): string {

This can be fixed by changing the relevant type signatures in TimeAgoPipe to moment.MomentInput instead of Date | moment.Moment.

Note: according to the Angular docs the fullTemplateTypeCheck option "will default to true in the future" (see https://angular.io/guide/aot-compiler#fulltemplatetypecheck).

Did you search for duplicate issue? Yes

Environment:

• Angular version? 7.0.2
• TypeScript version? 3.1.6
• moment version? 2.22.2
• Are you using moment-timezone? No
• Are you using the angular-cli? No
• Using Rollup/Webpack/System.js/Ionic/similar? Webpack