Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please excludes node_modules in the package #23

Closed
mkjeff opened this issue Mar 24, 2016 · 3 comments
Closed

Please excludes node_modules in the package #23

mkjeff opened this issue Mar 24, 2016 · 3 comments

Comments

@mkjeff
Copy link

mkjeff commented Mar 24, 2016

At this moment, releases ts source file is a good choose. but including angular2 module will break down the compatibility.

@urish
Copy link
Owner

urish commented Mar 24, 2016

node_modules should not be published with the npm package (see the files section of our package.json), but in some cases, npm install will create it inside the module folder.

@mkjeff
Copy link
Author

mkjeff commented Mar 24, 2016

thanks. how to avoid it?

@urish
Copy link
Owner

urish commented May 22, 2016

angular2 is now a peer dependency, which should fix this issue (see #24 for discussion)

@urish urish closed this as completed May 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants