Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keine Benachrichtigung bei Stornierungsanfragen an Abteilungsleiter #4671

Closed
honnel opened this issue May 22, 2024 · 0 comments · Fixed by #4679
Closed

Keine Benachrichtigung bei Stornierungsanfragen an Abteilungsleiter #4671

honnel opened this issue May 22, 2024 · 0 comments · Fixed by #4679
Assignees
@honnel
Labels
status: planned This issue is planned in a milestone and won't be touched by stale bot. type: bug Something's wrong
Milestone
5.3.0

Comments

@honnel
Copy link
Contributor

honnel commented May 22, 2024 •
edited by derTobsch
Loading

Describe the bug
Ein Abteilungsleiter bekommt trotz passenden Berechtigungen und Benachrichtigungseinstellungen keine E-Mail bei Stornierungsanfragen.

To Reproduce
Steps to reproduce the behavior:

  1. User und DepartmentHead in Abteilung A
  2. DepartmentHead ist Abteilungsleiter von Abteilung A
  3. DepartmentHead hat die Berechtigung "Pflege von Abwesenheiten" und die Benachrichtungseinstellung "Stornierungsanfragen" ist aktiv
  4. Genehmigter Antrag von User wird die Stornierung angefragt
  5. Es kommt keine Mail für den DepartmentHead

analog zu chef und Freigabe-Verantwortlicher.

Expected behavior
Es kommt eine Mail für den DepartmentHead für die Stornierungsanfrage

Additional context
Hier wird nur auf isValidWith(List.of(USER, DEPARTMENT_HEAD) geprüft: https://github.com/urlaubsverwaltung/urlaubsverwaltung/blob/main/src/main/java/org/synyx/urlaubsverwaltung/mail/MailRecipientServiceImpl.java#L68
Erwartet wäre aber USER, DEPARTMENT_HEAD und APPLICATION_CANCELLATION_REQUESTED: https://github.com/urlaubsverwaltung/urlaubsverwaltung/blob/main/src/main/java/org/synyx/urlaubsverwaltung/person/MailNotification.java#L30
@honnel honnel added type: bug Something's wrong status: new Initial state for every issue / pullrequest labels May 22, 2024
@honnel honnel added this to the 5.3.0 milestone May 22, 2024
@github-actions github-actions bot added status: planned This issue is planned in a milestone and won't be touched by stale bot. and removed status: new Initial state for every issue / pullrequest labels May 22, 2024
@derTobsch derTobsch mentioned this issue May 23, 2024
Merged
@honnel honnel self-assigned this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@honnel honnel

Labels
status: planned This issue is planned in a milestone and won't be touched by stale bot. type: bug Something's wrong
Projects
None yet
Milestone
5.3.0
1 participant
@honnel