Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Sphinx 3 #1842

Closed
pquentin opened this issue Apr 7, 2020 · 4 comments
Closed

Switch to Sphinx 3 #1842

pquentin opened this issue Apr 7, 2020 · 4 comments

Comments

@pquentin
Copy link
Member

pquentin commented Apr 7, 2020

Here's the changelog: https://www.sphinx-doc.org/en/master/changes.html#release-3-0-0-released-apr-06-2020

It currently fails with an mysterious ValueError: wrapper loop when unwrapping <MockModule id='139897808864312'> error: https://travis-ci.org/github/urllib3/urllib3/jobs/671484869
@sethmlarson
Copy link
Member

This was resolved in #1844

@pradyunsg
Copy link
Contributor

From https://urllib3.readthedocs.io/en/latest/reference/urllib3.connectionpool.html:

<meta name="generator" content="sphinx-1.8.5, furo">

I don't think so...

@pradyunsg
Copy link
Contributor

ReadTheDocs does a pip install containing sphinx<2 prior to doing pip install ... -r docs/requirements.txt. I think adding a sphinx>3.0.0 would work!

@sethmlarson sethmlarson reopened this Sep 15, 2020
@pradyunsg
Copy link
Contributor

#1964 fixed this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pquentin @pradyunsg @sethmlarson