Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit runs "twine check". I reused @sethmlarson's code from hip, but simplified it since
twine check
returns a non-zero error code on failure. You can see the check working as expected here: https://github.com/pquentin/urllib3/runs/593112721?check_suite_focus=trueThe second commits fixes the twine warnings by:
Parsing README.rst is quite brittle, what do you think? It works now (see the resulting PKG-INFO), but who knows how it could break in the future.
Closes #1854