Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: Consider moving SSL-related options to a wrapped SSLContext helper #2111

Open
shazow opened this issue Dec 16, 2020 · 0 comments
Open

v2: Consider moving SSL-related options to a wrapped SSLContext helper #2111

shazow opened this issue Dec 16, 2020 · 0 comments

Comments

@shazow
Copy link
Member

shazow commented Dec 16, 2020

(Placeholder braindump from our team meeting on 2020-12-16)

We have a bunch of SSL-related options that are confusing (server_hostname, assert_hostname, etc).

If we wanted to make a bigger change for v2 to change the signatures in a meaningful way, we can consider adding an SSLContext-like object in urllib3 which wraps the stdlib SSLContext, but also move all of our backports into that code and add all of the SSL-adjacent functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants