Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the parameters for urllib3.request() #3011

Closed
brettcannon opened this issue May 3, 2023 · 8 comments · Fixed by #3177
Closed

Document the parameters for urllib3.request() #3011

brettcannon opened this issue May 3, 2023 · 8 comments · Fixed by #3177
Assignees
Labels
💰 Bounty $100 If you complete this issue we'll pay you $100 on OpenCollective!

Comments

@brettcannon
Copy link

Context

https://urllib3.readthedocs.io/en/stable/reference/urllib3.request.html has no details on any of its parameters. I assume they ultimately come from https://urllib3.readthedocs.io/en/stable/reference/urllib3.connectionpool.html#urllib3.HTTPConnectionPool.urlopen except for the json parameter which seems to be indirectly documented via https://urllib3.readthedocs.io/en/stable/user-guide.html#json . But since this is meant to be the high-level API that folks might grab over e.g. requests, directly documenting or linking to the appropriate function for details would probably be helpful.

Contribution

Would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)

Yes, I'm willing to help out with a PR depending on how you want the docs to look.

@geeksambhu
Copy link

Hi @brettcannon, I would love to work on this

@sethmlarson
Copy link
Member

@geeksambhu Great! Ideally I would like all of this documented at the top of the User Guide.

@geeksambhu
Copy link

@sethmlarson, I will work on the User Guide, Can you please assign this to me?

@sethmlarson
Copy link
Member

@geeksambhu We don't assign folks to issues unless there's a created PR, as you can imagine there's a high number of people that say they'll contribute but then life gets in the way and we don't want to discourage others from working on something until there's proof that the effort would be duplicated. Hope you understand!

@brettcannon
Copy link
Author

Ideally I would like all of this documented at the top of the User Guide.

So you don't want the parameter details in the API/reference docs? Or are you saying you would like to have them covered in both the reference guide and the user guide?

@sethmlarson sethmlarson added the 💰 Bounty $100 If you complete this issue we'll pay you $100 on OpenCollective! label Nov 3, 2023
@sethmlarson
Copy link
Member

@alexwlchan has an open PR for this issue, so marking it as claimed.

@alexwlchan
Copy link
Contributor

@sethmlarson Are you waiting for anything more from me of that PR, or is it just waiting for a reviewer to have time for it?

@sethmlarson
Copy link
Member

@alexwlchan Reviewer to have time! Sorry about the delay :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💰 Bounty $100 If you complete this issue we'll pay you $100 on OpenCollective!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants