-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the parameters for urllib3.request()
#3011
Comments
Hi @brettcannon, I would love to work on this |
@geeksambhu Great! Ideally I would like all of this documented at the top of the User Guide. |
@sethmlarson, I will work on the User Guide, Can you please assign this to me? |
@geeksambhu We don't assign folks to issues unless there's a created PR, as you can imagine there's a high number of people that say they'll contribute but then life gets in the way and we don't want to discourage others from working on something until there's proof that the effort would be duplicated. Hope you understand! |
So you don't want the parameter details in the API/reference docs? Or are you saying you would like to have them covered in both the reference guide and the user guide? |
@alexwlchan has an open PR for this issue, so marking it as claimed. |
@sethmlarson Are you waiting for anything more from me of that PR, or is it just waiting for a reviewer to have time for it? |
@alexwlchan Reviewer to have time! Sorry about the delay :) |
Context
https://urllib3.readthedocs.io/en/stable/reference/urllib3.request.html has no details on any of its parameters. I assume they ultimately come from https://urllib3.readthedocs.io/en/stable/reference/urllib3.connectionpool.html#urllib3.HTTPConnectionPool.urlopen except for the
json
parameter which seems to be indirectly documented via https://urllib3.readthedocs.io/en/stable/user-guide.html#json . But since this is meant to be the high-level API that folks might grab over e.g. requests, directly documenting or linking to the appropriate function for details would probably be helpful.Contribution
Would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)
Yes, I'm willing to help out with a PR depending on how you want the docs to look.
The text was updated successfully, but these errors were encountered: