Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TODO about informational responses #3319

Merged
merged 1 commit into from Feb 1, 2024

Conversation

pquentin
Copy link
Member

Today it's not possible with HTTP/1.1 (see psf/requests#713) and even python-hyper does not handle this case.

Today it's not possible with HTTP/1.1 (see psf/requests#713) and even
python-hyper does not handle this case.
@pquentin pquentin added the Skip Changelog Pull requests that don't require a changelog entry label Jan 25, 2024
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is it possible to send a 1xx response from ASGI?

@sigmavirus24
Copy link
Contributor

I'm not sure what we might want here but I think there are use cases that make sense and we shouldn't automatically limit things because http lib sucks in this way.

See also python/cpython#42550 and no one having fixed this yet

@pquentin
Copy link
Member Author

pquentin commented Feb 1, 2024

LGTM, is it possible to send a 1xx response from ASGI?

Yes, early hints are explicitly supported: https://asgi.readthedocs.io/en/stable/extensions.html#early-hints. Good point.

I'm not sure what we might want here but I think there are use cases that make sense and we shouldn't automatically limit things because http lib sucks in this way.

My reasoning is that there's no point in cluttering the code with something we're not going to implement right away. It's not just a comment, it's an actual condition that is evaluated. An open issue in the HTTP/2 milestone makes more sense to me. I opened #3336, and will merge this given there's one approval.

@pquentin pquentin merged commit 23f2287 into urllib3:main Feb 1, 2024
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Pull requests that don't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants