Fix issue where InsecureRequestWarning is emitted for HTTPS Emscripte… #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
force-pushed
the
emscripten-is-verified
branch
2 times, most recently
from
e643943
to
dcb177b
Compare
sethmlarson
force-pushed
the
emscripten-is-verified
branch
from
dcb177b
to
c5dc9ba
Compare
pquentin
reviewed
Feb 8, 2024
|
|
||
| http = urllib3.PoolManager() | ||
|
|
||
| with warnings.catch_warnings(record=True) as w: |
There was a problem hiding this comment.
CI fails because you haven't imported warnings
There was a problem hiding this comment.
Thanks! Fixed in 2758cab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n requests
Closes #3331 I wasn't able to get tests to run locally and spent a bunch of time trying to get Jupyterlite+micropip to install a local wheel file to no avail 😢 So will be relying on CI for this one, unfortunately. We really need #3330