Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please ship test-requirements.txt or avoid using it #47

Closed
eriol opened this issue Feb 6, 2012 · 2 comments
Closed

Please ship test-requirements.txt or avoid using it #47

eriol opened this issue Feb 6, 2012 · 2 comments

Comments

@eriol
Copy link

eriol commented Feb 6, 2012

Hello,
test-requirements.txt is not shipped with the source so installing urllib3. However I think that listing requirements inside setup.py is a better choice.

$ pip install urllib3
Downloading/unpacking urllib3
  Downloading urllib3-1.2.1.tar.gz
  Running setup.py egg_info for package urllib3
    Traceback (most recent call last):
      File "<string>", line 14, in <module>
      File "/home/eriol/.virtualenvs/testurllib3/build/urllib3/setup.py", line 25, in <module>
        tests_requirements = requirements + open('test-requirements.txt').readlines()
    IOError: [Errno 2] No such file or directory: 'test-requirements.txt'
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):

  File "<string>", line 14, in <module>

  File "/home/eriol/.virtualenvs/testurllib3/build/urllib3/setup.py", line 25, in <module>

    tests_requirements = requirements + open('test-requirements.txt').readlines()

IOError: [Errno 2] No such file or directory: 'test-requirements.txt'

Kind regards,
Daniele Tricoli

@shazow shazow closed this as completed in 751880f Feb 6, 2012
@shazow
Copy link
Member

shazow commented Feb 6, 2012

Sorry about that, @eriolv.

It's funny because @kennethreitz and I were just talking last night about his new API which tests the packaging and I scoffed at it and it totally would have caught it. :P You win, @kennethreitz.

@eriol
Copy link
Author

eriol commented Feb 9, 2012

Thanks for fixing it and don't worry! :)
I'm packaging urllib3 for Debian[¹] and I always try to avoid custom patch, if the problem can be fixed upsream.

Many thanks for your fast reply.

Cheers,
Daniele Tricoli

[¹] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=648783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants