gevent socket does not raise SocketTimeout and Timeouts fail

[lukecampbell]

The gevent monkey patching on socket for some reason (have yet to find out why) does not properly raise a SocketTimeout the way it should and as a consequence urllib3 will not raise a Timeout properly if you're using gevent.

How to reproduce:
Create unresponsive socket (simulate timeout)

nc -l 8080

from gevent.monkey import patch_all
patch_all()
import urllib3
http = urllib3.PoolManager()
r = http.request('GET', 'http://localhost:8080/',timeout=1)

The Timeout is never raised.

One solution is to use gevent.socket when making the connection, that should properly raise a SocketTimeout.

[shazow]

Sorry for the superlate response.

That is an annoying bug indeed. Any thoughts on how to implement it in such a way that it won't break other platforms?

[wynnw]

This is a gevent bug - I ran into it today. It appears to have been fixed in this gevent commit:
https://bitbucket.org/denis/gevent/changeset/65968cf1baa9

Hopefully a 1.0b3 will come out soon with that fix.