You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Assuming that there is one list of urls, wouldn't we want to go through all of them, update check_results as we go, and return the final two lists? I'm working on a PR now, I can update this to fix the issue (if it isn't intentional!)
The text was updated successfully, but these errors were encountered:
You are totally right 👍 That return should be outside of the for loop. That explains some of the weird behaviours mentioned in #8. I will be looking to your PR.
I'm not sure if this is intentional, but the list of check_results is returned after just parsing one of the urls in the list:
https://github.com/urlstechie/URLs-checker/blob/3200baf59d73c3e8c0fd92e9ce73c375603b4b2b/core/urlproc.py#L59
Assuming that there is one list of urls, wouldn't we want to go through all of them, update check_results as we go, and return the final two lists? I'm working on a PR now, I can update this to fix the issue (if it isn't intentional!)
The text was updated successfully, but these errors were encountered: