Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check results returned before loop completed #16

Closed
vsoch opened this issue Mar 9, 2020 · 1 comment
Closed

Check results returned before loop completed #16

vsoch opened this issue Mar 9, 2020 · 1 comment

Comments

@vsoch
Copy link
Collaborator

vsoch commented Mar 9, 2020

I'm not sure if this is intentional, but the list of check_results is returned after just parsing one of the urls in the list:

https://github.com/urlstechie/URLs-checker/blob/3200baf59d73c3e8c0fd92e9ce73c375603b4b2b/core/urlproc.py#L59

Assuming that there is one list of urls, wouldn't we want to go through all of them, update check_results as we go, and return the final two lists? I'm working on a PR now, I can update this to fix the issue (if it isn't intentional!)

@SuperKogito
Copy link
Member

You are totally right 👍 That return should be outside of the for loop. That explains some of the weird behaviours mentioned in #8. I will be looking to your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants