code refactoring and unit testing #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! Can you give me some more info about the unit testing etc.? Is it something to do with CircleCI/Fastlane? Edit: for the about card, you can simply copy/paste the code of my own about card in the About Page of the app, and replace my details with yours. |
|
Unit testing is basically testing/validating units of plain code, which is the code that can be run in the virtual machine without any emulator/physical device. About CI, I'm actually not sure because I have never done any CI before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 馃槃 ,
Everything should be fixed in the code now, sorry about that.
I added basic unit testing to the repository.
I didn't do any integration tests yet. I might do that soon.
I refactored the services to interfaces, and set up the composition root for our dependencies in app
main.Now every dependency is manually injected to facilitate integration tests !
Oh btw, how do you imagine the card? i suck at UI/UX 馃槅.
edit: feel free to comment any line or ask about anything in the code, i'll gladly explain anything 馃槉