Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-3908: Test write_csv compression #95

Merged
merged 4 commits into from
May 20, 2022
Merged

ENG-3908: Test write_csv compression #95

merged 4 commits into from
May 20, 2022

Conversation

boshek
Copy link
Collaborator

@boshek boshek commented May 18, 2022

Closes #80

I have only added in gzip for compression as this works across all writers. I can do further configuration if needed if other compression types are desired. For example do we want to benchmark all the arrow compression options?

Closed Should only be merged once ARROW-16144 is closed

@boshek boshek marked this pull request as ready for review May 18, 2022 21:30
R/bm-write-csv.R Outdated Show resolved Hide resolved
Copy link
Contributor

@alistaire47 alistaire47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should add a story to go add this to the {benchmarks} code that calls this once this is merged, too

R/bm-write-csv.R Outdated Show resolved Hide resolved
R/bm-write-csv.R Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test write_csv compression
3 participants