Skip to content

Commit

Permalink
Fix null run_id (#153)
Browse files Browse the repository at this point in the history
  • Loading branch information
dianaclarke committed Aug 21, 2021
1 parent daa57cb commit 0574870
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
6 changes: 4 additions & 2 deletions conbench/app/compare.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,10 @@ def page(self, comparisons, regressions, improvements, baseline_id, contender_id
baseline_run, contender_run = None, None

if comparisons and self.type == "batch":
baseline_run_id = comparisons[0]["baseline_run_id"]
contender_run_id = comparisons[0]["contender_run_id"]
ids = {c["baseline_run_id"] for c in comparisons if c["baseline_run_id"]}
baseline_run_id = ids.pop() if ids else None
ids = {c["contender_run_id"] for c in comparisons if c["contender_run_id"]}
contender_run_id = ids.pop() if ids else None
compare = f"{baseline_run_id}...{contender_run_id}"
compare_runs_url = f.url_for("app.compare-runs", compare_ids=compare)
elif comparisons and self.type == "run":
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

setuptools.setup(
name="conbench",
version="1.10.0",
version="1.11.0",
description="Continuous Benchmarking (CB) Framework",
long_description=long_description,
long_description_content_type="text/markdown",
Expand Down

0 comments on commit 0574870

Please sign in to comment.