More UI tweaks (#83)

conbench · Jun 10, 2021 · 19cee69 · 19cee69
1 parent 865b14f
commit 19cee69
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 17 deletions.
diff --git a/conbench/static/app.css b/conbench/static/app.css
@@ -27,11 +27,6 @@ table.dataTable thead .sorting_desc {
   cursor: pointer;
 }
 
-.tooltip-inner {
-    max-width: 250px;
-    width: 250px;
-}
-
 .table.dataTable a {
   color: #1F77B4;
 }
@@ -56,6 +51,16 @@ table.dataTable thead .sorting_desc {
 
 .tooltip-inner {
   background-color: #282828;
+  max-width: 250px;
+  width: 250px;
+}
+
+.tooltip.bottom .tooltip-arrow {
+  top: 0;
+  left: 50%;
+  margin-left: -5px;
+  border-bottom-color: #282828;
+  border-width: 0 5px 5px;
 }
 
 .carousel-control.left,.carousel-control.right {
@@ -79,3 +84,10 @@ table.dataTable thead .sorting_desc {
   white-space: nowrap;
   overflow: hidden;
 }
+
+.ellipsis-500 {
+  width: 500px;
+  text-overflow: ellipsis;
+  white-space: nowrap;
+  overflow: hidden;
+}
diff --git a/conbench/templates/benchmark-entity.html b/conbench/templates/benchmark-entity.html
@@ -26,8 +26,7 @@
           <li class="list-group-item active">Benchmark</li>
             <li class="list-group-item" style="overflow-y: auto;">
               <b>benchmark</b>
-              <br>
-              <div align="right" style="display:inline-block; float: right;">
+              <div class="ellipsis-500" align="right" style="display:inline-block; float: right;">
                 {{ benchmark.display_name }}
               </div>
             </li>
@@ -74,8 +73,7 @@
             <li class="list-group-item active">Commit</li>
             <li class="list-group-item" style="overflow-y: auto;">
               <b>commit</b>
-              <br>
-              <div align="right" style="display:inline-block; float: right;">
+              <div class="ellipsis-500" align="right" style="display:inline-block; float: right;">
                 <a href="{{ run.commit.url }}">{{ run.commit.message }}</a>
               </div>
             </li>

diff --git a/conbench/templates/compare-entity.html b/conbench/templates/compare-entity.html
@@ -104,8 +104,7 @@
             {% if baseline_run %}
             <li class="list-group-item" style="overflow-y: auto;">
               <b>commit</b>
-              <br>
-              <div align="right" style="display:inline-block; float: right;">
+              <div class="ellipsis-500" align="right" style="display:inline-block; float: right;">
                 <a href="{{ baseline_run.commit.url }}">{{ baseline_run.commit.message }}</a>
               </div>
             </li>
@@ -198,8 +197,7 @@
             {% if contender_run %}
             <li class="list-group-item" style="overflow-y: auto;">
               <b>commit</b>
-              <br>
-              <div align="right" style="display:inline-block; float: right;">
+              <div class="ellipsis-500" align="right" style="display:inline-block; float: right;">
                 <a href="{{ contender_run.commit.url }}">{{ contender_run.commit.message }}</a>
               </div>
             </li>

diff --git a/conbench/templates/compare-list.html b/conbench/templates/compare-list.html
@@ -80,13 +80,17 @@
                 <tbody>
                     {% for c in comparisons %}
                     <tr>
-                         {% if c.contender is none %}
-                           <td>---</td>
-                         {% else %}
+                         {% if c.contender is not none and c.baseline is not none %}
                            <td>{{ c.contender_z_score }}</td>
+                         {% else %}
+                           <td>---</td>
                          {% endif %}
 
-                         <td>{{ c.change }}</td>
+                         {% if c.contender is not none and c.baseline is not none %}
+                           <td>{{ c.change }}</td>
+                         {% else %}
+                           <td>---</td>
+                         {% endif %}
 
                          <td>
                            {% if type == "batch" %}