Do not add timing options to case tags

conbench · Apr 7, 2021 · 64b1e2b · 64b1e2b
1 parent 6d8ae68
commit 64b1e2b
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 10 deletions.
diff --git a/conbench/runner.py b/conbench/runner.py
@@ -136,10 +136,6 @@ def benchmark(self, f, name, tags, context, run, options):
             "time_unit": "s",
         }
 
-        # TODO: don't add to tags for now for backwards compatibility
-        del timing_options["drop_caches"]
-
-        tags.update(timing_options)
         context.update(self.language)
         benchmark, _ = self.record(
             result,

diff --git a/conbench/tests/benchmark/test_runner.py b/conbench/tests/benchmark/test_runner.py
@@ -68,8 +68,6 @@
     },
     "tags": {
         "year": "2020",
-        "gc_collect": True,
-        "gc_disable": True,
         "name": "addition",
     },
 }
@@ -85,8 +83,6 @@ def test_runner_without_cases():
     assert not BenchmarkFacadeSchema.create.validate(result)
     expected_tags = {
         "year": "2020",
-        "gc_collect": True,
-        "gc_disable": True,
         "name": "addition",
     }
     assert output == 2
@@ -111,8 +107,6 @@ def test_runner_with_cases():
         "fruit": "apple",
         "count": 1,
         "dataset": "sample",
-        "gc_collect": True,
-        "gc_disable": True,
         "name": "subtraction",
     }
     assert output == 99