URSA-253 > Do not expect author field in github /commits/id response …

…and do not try requests with 500 responses
conbench · Mar 15, 2021 · 6867867 · 6867867
1 parent 197b38d
commit 6867867
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/conbench/entities/commit.py b/conbench/entities/commit.py
@@ -50,6 +50,6 @@ def parse_commit(commit):
         "date": dateutil.parser.isoparse(commit["commit"]["author"]["date"]),
         "message": commit["commit"]["message"].split("\n")[0],
         "author_name": commit["commit"]["author"]["name"],
-        "author_login": commit["author"]["login"],
-        "author_avatar": commit["author"]["avatar_url"],
+        "author_login": commit["author"]["login"] if commit["author"] else None,
+        "author_avatar": commit["author"]["avatar_url"] if commit["author"] else None,
     }
diff --git a/conbench/util.py b/conbench/util.py
@@ -14,7 +14,7 @@
 
 retry_strategy = Retry(
     total=5,
-    status_forcelist=[500, 502, 503, 504],
+    status_forcelist=[502, 503, 504],
     allowed_methods=frozenset(["GET", "POST"]),
     backoff_factor=4,  # will retry in 2, 4, 8, 16, 32 seconds
 )