Handle empty history response (#136)

conbench/app/_plots.py

@@ -7,14 +7,16 @@
 
 
 class TimeSeriesPlotMixin:
-    def _get_history_plot(self, benchmark):
+    def get_history_plot(self, benchmark):
         history = self._get_history(benchmark)
-        return json.dumps(
-            bokeh.embed.json_item(
-                time_series_plot(history, benchmark["id"]),
-                "plot-history",
+        if history:
+            return json.dumps(
+                bokeh.embed.json_item(
+                    time_series_plot(history, benchmark["id"]),
+                    "plot-history",
+                )
             )
-        )
+        return None
 
     def _get_history(self, benchmark):
         response = self.api_get("api.history", benchmark_id=benchmark["id"])

conbench/app/benchmarks.py

@@ -125,7 +125,7 @@ def page(self, benchmark, run, form):
             run=run,
             form=form,
             resources=bokeh.resources.CDN.render(),
-            plot_history=self._get_history_plot(benchmark),
+            plot_history=self.get_history_plot(benchmark),
         )
 
     def get(self, benchmark_id):

conbench/app/compare.py

@@ -31,7 +31,7 @@ def page(self, comparisons, regressions, improvements, baseline_id, contender_id
             baseline = self.get_display_benchmark(baseline_id)
             contender = self.get_display_benchmark(contender_id)
             plot = self._get_plot(baseline, contender)
-            plot_history = self._get_history_plot(contender)
+            plot_history = self.get_history_plot(contender)
             baseline_run_id = baseline["run_id"]
             contender_run_id = baseline["run_id"]
             compare = f"{baseline_run_id}...{contender_run_id}"

conbench/templates/benchmark-entity.html

@@ -149,9 +149,11 @@
     $("#benchmark-form").find("#delete").attr("data-message", "<ul><li>Delete benchmark: <strong>{{ benchmark.id }}</strong></li></ul>");
 });
 
+{% if plot_history %}
 $(document).ready(function() {
     Bokeh.embed.embed_item({{ plot_history | safe }});
 });
+{% endif %}
 
 </script>
 {% endblock %}

conbench/templates/compare-entity.html

@@ -283,9 +283,11 @@
     Bokeh.embed.embed_item({{ plot | safe }});
 });
 
+{% if plot_history %}
 $(document).ready(function() {
     Bokeh.embed.embed_item({{ plot_history | safe }});
 });
+{% endif %}
 
 $(document).ready(function() {
     $('#unit-tooltip').tooltip()