Just redirect to app index for now

conbench · Aug 17, 2021 · 873fc55 · 873fc55
1 parent 354c422
commit 873fc55
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/conbench/api/_endpoint.py b/conbench/api/_endpoint.py
@@ -48,6 +48,9 @@ def validate(self, schema):
 
         return data
 
+    def redirect(self, endpoint, **kwargs):
+        return f.redirect(f.url_for(endpoint, **kwargs))
+
     def abort_400_bad_request(self, message):
         if not isinstance(message, dict):
             message = {"_errors": [message]}

diff --git a/conbench/api/auth.py b/conbench/api/auth.py
@@ -85,7 +85,7 @@ def get(self):
         ---
         description: Google SSO callback.
         responses:
-            "204": "204"
+            "302": "302"
             "400": "400"
         tags:
           - Authentication
@@ -105,7 +105,7 @@ def get(self):
                 }
                 user = User.create(data)
             flask_login.login_user(user)
-            return self.response_204_no_content()
+            return self.redirect("app.index")
         except:
             self.abort_400_bad_request("Google SSO failed.")
 

diff --git a/conbench/tests/api/_expected_docs.py b/conbench/tests/api/_expected_docs.py
@@ -1127,7 +1127,7 @@
             "get": {
                 "description": "Google SSO callback.",
                 "responses": {
-                    "204": {"$ref": "#/components/responses/204"},
+                    "302": {"$ref": "#/components/responses/302"},
                     "400": {"$ref": "#/components/responses/400"},
                 },
                 "tags": ["Authentication"],